Skip to content

[css-grid] comma in repeat() #334

Closed
Closed

Description

@fantasai

In light of recent discussions on commas inside functional notations (issue #266, https://wiki.csswg.org/ideas/functional-notation#general-principles) ... shouldn't the comma in repeat() be dropped?

Activity

  1. FremyCompany commented on Jul 20, 2016

    @FremyCompany
    Contributor

    It could be confusing though because repeat(3 0) would be a valid way to create 3 empty tracks.

  2. rachelandrew commented on Jul 21, 2016

    @rachelandrew
    Contributor

    I think it would be very confusing. The comma is useful here and I see no benefit from removing it.

  3. fantasai commented on Jul 26, 2016

    @fantasai
    CollaboratorAuthor

    The benefit would be to have the contents of the functional notation follow the syntax conventions of CSS property values. (Which don't use commas except for fallbacks/layering/lists.)

  4. FremyCompany commented on Jul 27, 2016

    @FremyCompany
    Contributor

    An option would be to do repeat(3x [line] 100px) or repeat(3: [line] 100px)

  5. FremyCompany commented on Jul 27, 2016

    @FremyCompany
    Contributor

    Actually the first one isn't a good idea, 3x looks like 3px where you forgot the p.

  6. svillar commented on Jul 27, 2016

    @svillar

    I also find the syntax without the comma very confusing. And in any case the WG is not proposing to change anything in grid, nor even minmax() which is considered a math-y function.

  7. tabatkins commented on Aug 2, 2016

    @tabatkins
    Member

    @fantasai and I have talked about this, and agreed not to change Grid in this respect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions