Skip to content

[css-grid-1] Grid baseline should only take baseline from spanning cells participating in the first/last row #5293

Closed
Closed
[css-grid-1] Grid baseline should only take baseline from spanning cells participating in the first/last row#5293
Labels
Closed Accepted as Obvious BugfixFixed an obvious error with the obvious solution.css-grid-1

Description

@fantasai
fantasai
opened on Jul 6, 2020

Currently the spec says

If any of the grid items whose areas intersect the grid container’s first (last) row participate in baseline alignment, the grid container’s baseline set is generated from the shared alignment baseline of those grid items.

But actually this should be limited to the items participating in baseline alignment in that row, since a spanning cell could be participating in baseline alignment in a different row.

P.S. Also that should be “non-empty row”, to be consistent with #3645

Activity

  1. fantasai
    added
    css-grid-1
    Closed Accepted as Obvious BugfixFixed an obvious error with the obvious solution.
    Target Revision: CurrentRemove when done.
    on Jul 6, 2020
  2. tabatkins
    closed this as completedin 916d458on Jul 6, 2020
  3. fantasai
    added
    Closed Accepted as Obvious BugfixFixed an obvious error with the obvious solution.
    and removed
    Target Revision: CurrentRemove when done.
    Closed Accepted as Obvious BugfixFixed an obvious error with the obvious solution.
    on Jul 6, 2020
  4. fantasai
    added 3 commits that reference this issue on Jul 7, 2020

    [css-grid] Check that 'align-self: last baseline' does not interfere …

    aab1016

    [css-grid] Check that 'align-self: last baseline' does not interfere …

    c3fdcba

    [css-grid] Check that 'align-self: last baseline' does not interfere …

    e3698c7
  5. moz-v2v-gh
    added a commit that references this issue on Jul 10, 2020

    Bug 1650966 [wpt PR 24477] - [css-grid] Check that 'align-self: last …

    7f82acf
  6. xeonchen
    added a commit that references this issue on Jul 10, 2020

    Bug 1650966 [wpt PR 24477] - [css-grid] Check that 'align-self: last …

    4a356a3
  7. webkit-commit-queue
    added a commit that references this issue on Apr 21, 2021

    [css-grid] last-baseline shouldn't affect baseline alignment

    d222a94
  8. yury-s
    added a commit that references this issue on Apr 21, 2021

    [css-grid] last-baseline shouldn't affect baseline alignment

    a62eeeb
  9. bhearsum
    added a commit that references this issue on May 1, 2025

    Bug 1650966 [wpt PR 24477] - [css-grid] Check that 'align-self: last …

    7ce68ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Closed Accepted as Obvious BugfixFixed an obvious error with the obvious solution.css-grid-1

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions