Skip to content

[css-counter-styles-3] Korean counter styles fallback #8870

Closed

Description

@nt1m

WPT & Chrome & Firefox say that Korean counter styles should fallback to cjk-decimal. WebKit and the spec don't mention a fallback for Korean counter styles.

Given CJK stands for Chinese/Japanese/Korean, I assume this is just the spec overlooking the fallback?

cc @fantasai @tabatkins

Activity

  1. tabatkins commented on May 25, 2023

    @tabatkins
    Member

    ...huh. Okay, doing some archeology, I find that 7ebc754 is the commit that switched the Korean styles from being defined in prose to being defined with @counter-style; the deleted text clearly said that all of them should use cjk-decimal as fallback, but for some reason I only added that descriptor for the japanese styles.

    A week prior, this email between me and Koji established that we should fallback to cjk-decimal; that was implemented in 20a3d9c.

    So as far as I can tell, I just made a mistake and nobody ever caught it? I suppose I'll put the fallback back in the spec. ^_^

  2. tabatkins commented on May 25, 2023

    @tabatkins
    Member

    Uggggh, this was committed in fd972cf along with some editorial markup fixes; I'd meant to commit these two separately but accidentally typo'd the first commit and didn't realize so instead they got committed together. Oh well.

  3. tabatkins commented on May 25, 2023

    @tabatkins
    Member

    Agenda+ to confirm the change, since this is CR.

  4. css-meeting-bot commented on Jun 21, 2023

    @css-meeting-bot
    Member

    The CSS Working Group just discussed [css-counter-styles-3] Korean counter styles fallback, and agreed to the following:

    • RESOLVED: Accept edits from the issue
    The full IRC log of that discussion <emilio> TabAtkins: real quick rubber-stamp. Several years back we agreed that korean falls back to cjk decimal but I did it wrong
    <emilio> ... and accidentally default to decimal now
    <emilio> RESOLVED: Accept edits from the issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions