You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[css-counter-styles-3] Korean counter styles fallback #8870
WPT & Chrome & Firefox say that Korean counter styles should fallback to cjk-decimal. WebKit and the spec don't mention a fallback for Korean counter styles.
Given CJK stands for Chinese/Japanese/Korean, I assume this is just the spec overlooking the fallback?
...huh. Okay, doing some archeology, I find that 7ebc754 is the commit that switched the Korean styles from being defined in prose to being defined with @counter-style; the deleted text clearly said that all of them should use cjk-decimal as fallback, but for some reason I only added that descriptor for the japanese styles.
Uggggh, this was committed in fd972cf along with some editorial markup fixes; I'd meant to commit these two separately but accidentally typo'd the first commit and didn't realize so instead they got committed together. Oh well.
The CSS Working Group just discussed [css-counter-styles-3] Korean counter styles fallback, and agreed to the following:
RESOLVED: Accept edits from the issue
The full IRC log of that discussion
<emilio> TabAtkins: real quick rubber-stamp. Several years back we agreed that korean falls back to cjk decimal but I did it wrong
<emilio> ... and accidentally default to decimal now
<emilio> RESOLVED: Accept edits from the issue
Activity
tabatkins commentedon May 25, 2023
...huh. Okay, doing some archeology, I find that 7ebc754 is the commit that switched the Korean styles from being defined in prose to being defined with
@counter-style; the deleted text clearly said that all of them should usecjk-decimalas fallback, but for some reason I only added that descriptor for the japanese styles.A week prior, this email between me and Koji established that we should fallback to cjk-decimal; that was implemented in 20a3d9c.
So as far as I can tell, I just made a mistake and nobody ever caught it? I suppose I'll put the fallback back in the spec. ^_^
tabatkins commentedon May 25, 2023
Uggggh, this was committed in fd972cf along with some editorial markup fixes; I'd meant to commit these two separately but accidentally typo'd the first commit and didn't realize so instead they got committed together. Oh well.
tabatkins commentedon May 25, 2023
Agenda+ to confirm the change, since this is CR.
[css-counter-styles] Korean counter styles should fallback to cjk-dec…
css-meeting-bot commentedon Jun 21, 2023
The CSS Working Group just discussed
[css-counter-styles-3] Korean counter styles fallback, and agreed to the following:RESOLVED: Accept edits from the issueThe full IRC log of that discussion
<emilio> TabAtkins: real quick rubber-stamp. Several years back we agreed that korean falls back to cjk decimal but I did it wrong<emilio> ... and accidentally default to decimal now
<emilio> RESOLVED: Accept edits from the issue