Skip to content

[css-flexbox] Use flex-order first or document-order first item's baseline? #995

Closed

Description

@fantasai

In #197, it was noted that there's an inconsistency between Grid and Flexbox in whether the baseline is taken from the first item in document order or visual order. Grid clearly defines using the visual (grid) order; flexbox should probably account for 'order' and 'flex-direction' as well.

Activity

  1. SelenIT commented on Feb 1, 2017

    @SelenIT
    Collaborator

    Using visually first flex item definitely makes more sense. As my quick test suggests, browsers also seem to consistently use the visually first item's baseline as a flex container baseline.

  2. astearns commented on Feb 22, 2017

    @astearns
    Member

    Would this be visually first or flex-order first? Given a dom-order 1-2-3 that's flex-ordered 2-1-3 then displayed in a reverse flex container so that it appears on the page as 3-1-2, which item is 'first'?

  3. fantasai commented on Feb 23, 2017

    @fantasai
    CollaboratorAuthor

    That's a good question, and I think it should be visually first. The goal of first-baseline alignment is to align the visually first line of text; last-baseline alignment the visually last. Aligning a random line of text somewhere in the middle of the box isn't helpful.

  4. astearns commented on Mar 1, 2017

    @astearns
    Member

    RESOLVED: take the visually first line when considering baseline alignment in flexboxes

  5. tabatkins commented on Mar 14, 2017

    @tabatkins
    Member

    Fixed in 620eb8c.

  6. added this to the milestone on Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions