[web-animations-2] Use dfn type for animation trigger values
#11664
Conversation
The values for "animation trigger state" and "animation trigger type" were defined with a `value` definition type. That type is reserved for CSS values: https://speced.github.io/bikeshed/#dfn-types This makes tools that crawl specs to extract machine-readable information wrongly assume that the spec introduces new CSS values. There is no specific definition type available for generic values. This update uses a regular `dfn` and updates references to these values accordingly.
|
Thanks for opening this PR! Regarding |
Per feedback, the values are indeed CSS values for the `animation-trigger-type` property defined in CSS Animations 2. This update replaces the definitions in web-animations-2 by references to the definitions in CSS Animations 2 not to end up with two places that define the values.
Ah, sorry, I had missed that, indeed! There should be only one normative definition of anything, so if css-animations-2 defines the values, web-animations-2 should reference them and not attempt to re-define them. I pushed a new commit that replaces the |
|
@tidoust thanks! LGTM.
In css-animations-2 we have a more user-facing definition which describes the behavior of each type for authors. |
The values for "animation trigger state" and "animation trigger type" were defined with a
valuedefinition type. That type is reserved for CSS values: https://speced.github.io/bikeshed/#dfn-typesThis makes tools that crawl specs to extract machine-readable information wrongly assume that the spec introduces new CSS values.
There is no specific definition type available for generic values. This update uses a regular
dfnand updates references to these values accordingly.