feat: re-implement relevant checks from the ctc package in core handlers
#1394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`HTM-053` is an INFO-level message that reports links to local files (absolute `file` URLs). This check is moved to the core OPSHandler checks, so we can safely disable the `ctc` package.
RSC-018 was introduced in the `ctc` package to check the images specified in the MathML `altimg` attribute exist in the container. EPUBCheck already has an error code for missing resources, namely `RSC-018`. This change adds a check for the `altimg` in OPSHandler, and suppresses `RSC-018`.
`HTM-046` and `HTM-048` check that HTML fixed-layout documents have viewport metadata. This change reimplements these checks in `OPSHandler30` so that the `ctc` package can be disabled.
`CSS-015` reports when a `link` element defining an alternative style sheet does not have a `title` attribute. This is required by HTML, see: https://html.spec.whatwg.org/multipage/links.html#the-link-is-an-alternative-stylesheet This check is moved to the core checkers (specifically, in `OPSHandler30`), so that the `ctc` package can be disabled.
mattgarrish
requested changes
Dec 2, 2022
mattgarrish
approved these changes
Dec 2, 2022
Base automatically changed from
feat/disabled-flawed-css-checks
to
release/v5.0.0
December 5, 2022 12:59
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reimplement HTM-046 and HTM-047 in OPSHandler30
HTM-046andHTM-048check that HTML fixed-layout documentshave viewport metadata.
This change reimplements these checks in
OPSHandler30so that thectcpackage can be disabled.report
RSC-018asRSC-007insteadRSC-018 was introduced in the
ctcpackage to check the imagesspecified in the MathML
altimgattribute exist in the container.EPUBCheck already has an error code for missing resources, namely
RSC-018.This change adds a check for the
altimgin OPSHandler, and suppressesRSC-018.move HTM-053 check to OPSHandler
HTM-053is an INFO-level message that reports links to local files(absolute
fileURLs).This check is moved to the core OPSHandler checks, so we can
safely disable the
ctcpackage.Note: these changes will only be effective when the
ctcpackage is removed.