Skip to content

[geometry] DOMMatrix scaleSelf() step 6 has a redundant originZ check #350

Closed

Description

@saschanaz

https://drafts.fxtf.org/geometry/#dom-dommatrix-scaleself

scaleSelf() step 6 says:

If scaleZ is not 1 or originZ is not 0 or -0, set is 2D of the current matrix to false.

But the originZ check is redundant because scaleSelf() internally calls translateSelf() in step 1 which does that check already.

I think we can remove the check, thoughts?

cc @bzbarsky

Activity

  1. dirkschulze commented on Jun 28, 2019

    @dirkschulze
    Contributor

    @saschanaz You mean

    or originZ is not 0 or -0

    can be removed? Agree, should have been done by translateSelf().

  2. added a commit that references this issue on Jun 28, 2019
    2da13ae
  3. saschanaz commented on Jun 28, 2019

    @saschanaz
    MemberAuthor

    Filed #351 🚅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions