Skip to content

Specify a predictable error type for unimplemented Element subtypes #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Specify a predictable error type for unimplemented Element subtypes #57

wants to merge 3 commits into from

Conversation

@eladalon1983
Copy link
Member

@eladalon1983 eladalon1983 commented May 31, 2022 •
edited by pr-preview bot
Loading

Fixes #55.

Preview | Diff

@eladalon1983 eladalon1983 requested review from jan-ivar and youennf May 31, 2022 12:07
@eladalon1983
Copy link
Member Author

eladalon1983 commented May 31, 2022

Note that this is currently under produceCropTarget(). Depending on which PR is merged first - this one or #50 - the other one will have to be updated.

@eladalon1983 eladalon1983 changed the title Unsupported subtypes Predictable failure path for unimplemented subtypes May 31, 2022
@eladalon1983 eladalon1983 changed the title Predictable failure path for unimplemented subtypes Specify a predictable error type for unimplemented Element subtypes May 31, 2022
@eladalon1983
Copy link
Member Author

eladalon1983 commented Jun 2, 2022 •
edited
Loading

During today's Editors' meeting, @jan-ivar and @youennf have been opposed to merging this PR. If you've changed your mind - great, let's merge. Otherwise - could you please explain why? For transparency's sake, I think it would be good to continue this discussion publicly. I know some folks would be interested, e.g. @yoavweiss.

@eladalon1983
Copy link
Member Author

eladalon1983 commented Jun 3, 2022 •
edited
Loading

What's the explanation for not merging this PR, btw? Is it the same as #54, or is it different?

I've found this side, which someone is intending to present at the next WebRTC WG interim. @jan-ivar / @youennf, I think it's one of you? Or possibly both? I bears mentioning that the claim I highlighted on this slide, would not have been valid if the present PR were merged.

image

CC @dontcallmedom @yoavweiss

@alvestrand
Copy link

alvestrand commented Jan 3, 2024

Needs to be updated after merge of #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jan-ivar jan-ivar Awaiting requested review from jan-ivar

@youennf youennf Awaiting requested review from youennf

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Need for a predictable error type for unimplemented Element subtypes

2 participants

@eladalon1983 @alvestrand