Skip to content

Conversation

@Iain-S
Copy link
Contributor

@Iain-S Iain-S commented Jun 9, 2021

  • Update eslint config file.
  • Fix formatting errors (and a couple of others).

  • I have "fixed" the d3 error by making it a global variable. Somewhat of a hack but it seems to be what most people do.
  • I have allowed unused variables in function definitions. Personally, I find it useful to see what arguments callbacks are being passed, even if I'm not using them. An alternative would be to use /*eslint-disable no-unused-vars*/ around all of the offending lines 🤮.
  • Most of the .js file changes are purely aesthetic (e.g. quotes and indentation) but visualisation_helpers.js and report.js have some minor logic changes you may want to check.

- Update eslint config file
- Fix formatting errors (and a couple of others)
@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit c3d86dc and detected 0 issues on this pull request.

View more on Code Climate.

@yeban yeban merged commit fd1a7d9 into wurmlab:master Jun 21, 2021
@yeban
Copy link
Contributor

yeban commented Jun 21, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants