Skip to content

fixing explicit categorical failure if to_numeric is false #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kzecchini merged 4 commits into from
Aug 24, 2020
Merged

fixing explicit categorical failure if to_numeric is false #79

kzecchini merged 4 commits into from
Aug 24, 2020

Conversation

@kzecchini
Copy link
Contributor

@kzecchini kzecchini commented May 19, 2020 •
edited
Loading

Quick bugifx for ExplicitCategoricalTransform. Issue is this was returning None if to_numeric was set to False. It should return the original data in this case.

Checklist

  • I squashed my commits to a reasonable number of descriptive commits.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@kzecchini
Copy link
Contributor Author

kzecchini commented May 21, 2020

looks like there are still some rpy2 issues... will need to spend some time debugging.

@kzecchini kzecchini merged commit 5c56307 into master Aug 24, 2020
@kzecchini kzecchini mentioned this pull request Aug 24, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reka-ww reka-ww reka-ww approved these changes

@mskarlinski-ww mskarlinski-ww Awaiting requested review from mskarlinski-ww

@briangrahamww briangrahamww Awaiting requested review from briangrahamww

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kzecchini @reka-ww