Skip to content

Conversation

@pierre-winter
Copy link
Collaborator

Ongoing documentation updates for new hires

Copy link
Collaborator

@briangrahamww briangrahamww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pierre-winter !

```
A separate configuration file, `config/hello_world_classifier_predict.json` is designed to make predictions using the cached model. (Ideally, we would use a different dataset but we are using the same tennis dataset here for simplicity. )
A separate configuration file, `config/hello_world_classifier_predict.json` is designed to make predictions using the cached model.
Ideally, we would use a different dataset to make predictions on, but we are using the same tennis dataset here for simplicity.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good callout. I realize we never mention this anywhere in the docs!

@briangrahamww briangrahamww marked this pull request as ready for review October 3, 2022 23:03
and find the predictions in the `cache` folder.

You can also inspect and run the `config/hello_world_classifier_eval.json` configuration file which produces a number of evaluation metrics to the log file.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why this statement was removed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was removed because that eval file does not exist in the repo. If someone had this file or a similar eval file historically let me know and I can put it back in!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 I misread the cluster file for classifier!

@pierre-winter pierre-winter merged commit edd6ed5 into master Oct 6, 2022
@pierre-winter pierre-winter deleted the update-docs branch October 6, 2022 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants