Skip to content

Fix: hide RichText placeholder during voice dictation (#12980) #13518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
p-r-a-v-i-n wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix: hide RichText placeholder during voice dictation (#12980) #13518

p-r-a-v-i-n wants to merge 2 commits into from

Conversation

@p-r-a-v-i-n
Copy link
Contributor

@p-r-a-v-i-n p-r-a-v-i-n commented Oct 29, 2025 •
edited
Loading

This PR fixes #12980

I don't currently have macOS or Windows dictation tools available to test with.
I would really appreciate help from someone who can verify the behavior there, especially with system voice dictation enabled.

@Srishti-j18
Copy link
Member

Srishti-j18 commented Oct 30, 2025 •
edited
Loading

Hi @p-r-a-v-i-n ,
I have tested your branch on my local Mac OS using the Chrome browser to check the behavior, and I found that the issue still persists.
(unmute to hear)

Screen.Recording.2025-10-30.at.7.44.35.PM.mov

Maybe you can look into how the title block handled this issue and make similar changes to resolve it.

Screen.Recording.2025-10-30.at.7.50.11.PM.mov

@p-r-a-v-i-n p-r-a-v-i-n force-pushed the fix/voice-dictation-placeholder branch from 8c8950d to b97380c Compare October 30, 2025 15:34
@p-r-a-v-i-n
Copy link
Contributor Author

p-r-a-v-i-n commented Oct 30, 2025 •
edited
Loading

HI @Srishti-j18 ,
Thank you so much for feedback and i really appreciate you took time to test this. thanks.

Maybe you can look into how the title block handled this issue and make similar changes to resolve it.

sorry i could not able figure out how title is being handled though i made some changes I hope this time it will listen to 'compositionstart' at the right time. I'd really appreciate if you verify from your end again. if it won't work then i think i should close this PR since i'm doing changes on asumption.

If i'm missing something please let me know

@Srishti-j18
Copy link
Member

Srishti-j18 commented Oct 30, 2025 •
edited
Loading

It's not working. Also, I am not the best person who can review your code, w8 until someone more experienced reviews it.

But I would say, don't do things based on assumptions. I saw your code, you have created a new class and then written some logic which seems independent of the existing codebase.

I think this might require some code digging in https://github.com/springload/draftail too.
Through browser inspector-> what is happening rn is that in the input field with id=id_body, its value is not changing with voice dictation, and it is changing from null to something when keyboard interaction is happening. But in the case of the title field with id=id_title, it's using different data-actions to detect the changes (keyboard or voice dictation).
So maybe search in that direction would help.

@p-r-a-v-i-n p-r-a-v-i-n force-pushed the fix/voice-dictation-placeholder branch from b97380c to d9e9519 Compare October 31, 2025 09:54
@p-r-a-v-i-n p-r-a-v-i-n force-pushed the fix/voice-dictation-placeholder branch from d9e9519 to df2b2e6 Compare October 31, 2025 10:22
@p-r-a-v-i-n
Copy link
Contributor Author

p-r-a-v-i-n commented Oct 31, 2025

HI @Srishti-j18 ,
It seems to be working now
https://github.com/user-attachments/assets/94c716b3-148f-496f-b41a-918fae507898

@p-r-a-v-i-n p-r-a-v-i-n force-pushed the fix/voice-dictation-placeholder branch from b7242c3 to 0363ad9 Compare October 31, 2025 11:06
@p-r-a-v-i-n
Copy link
Contributor Author

p-r-a-v-i-n commented Nov 13, 2025 •
edited
Loading

Hi @Srishti-j18 ,
can you add label "status: Need Reviews" to this PR ?

@thibaudcolas thibaudcolas added status:Needs Review component:Rich text type:Bug UX User experience and general design-related items labels Nov 13, 2025
@thibaudcolas thibaudcolas self-requested a review November 13, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thibaudcolas thibaudcolas Awaiting requested review from thibaudcolas

Assignees

No one assigned

Labels

component:Rich text status:Needs Review type:Bug UX User experience and general design-related items

Projects

Triage trial
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Accessibility issues with voice dictation in RichText

3 participants

@p-r-a-v-i-n @Srishti-j18 @thibaudcolas