Add MacOS support#410
Merged
Merged
Conversation
Collaborator
|
A test is failing, seems you need to adapt it to MacOS support. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #410 +/- ##
==========================================
+ Coverage 71.53% 71.58% +0.04%
==========================================
Files 46 46
Lines 6732 6736 +4
Branches 1495 1495
==========================================
+ Hits 4816 4822 +6
+ Misses 1346 1345 -1
+ Partials 570 569 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Owner
Author
|
Fixed the tests @faridyagubbayli |
1 similar comment
Owner
Author
|
Fixed the tests @faridyagubbayli |
Owner
Author
|
It looks like with the new test of the simulation_checks, we caught a failure case on this branch.
|
faridyagubbayli
approved these changes
Jun 23, 2024
faridyagubbayli
left a comment
Collaborator
There was a problem hiding this comment.
So happy to see us testing in MacOS too!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for M1 Apple processors to k-wave-python. This support only extends to shared memory parallel computations (OMP). CUDA execution is not supported on Apple M1.
This PR does not graciously tell the user that CUDA is not supported and instead throws a file not found when a GPU-accelerated simulation is attempted.
closes #69