fix: properly report size after memory.reset #5992
Open
+38
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #5795 where the memory size was not properly reported after calling memory.reset(). The fix ensures that the VMMemoryDefinition.current_length field is updated when resetting memory, making it consistent with how this field is updated during memory growth operations.
- Updates the
WasmMmap::reset()method to properly synchronize the memory definition with the internal size state - Adds a comprehensive test case that verifies memory size reporting after reset and subsequent grow operations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/vm/src/memory.rs | Updates the reset() method to set VMMemoryDefinition.current_length to 0, ensuring size consistency with the internal size field |
| tests/compilers/issues.rs | Adds test case issue_5795_memory_reset_size to verify that memory size is correctly reported after reset and can be grown again from size 0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I verified the
mmapmapping is preserved ifmemory.growis called and so we don't re-create a new one.Fixes: #5795