deps: bump wasm-smith and enable fuzzers #5994
Open
+222
−244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR bumps the wasm-smith dependency from version 0.4.4 to 0.243.0 and updates the fuzzer targets to work with the new API. The changes improve error messages by including type information and modernize the fuzzer configuration to use the newer wasm-smith Config API directly instead of the deprecated ConfiguredModule wrapper.
Key changes:
- Updates wasm-smith from 0.4.4 to 0.243.0, transitioning from the old Config trait to the new wasm_smith::Config struct API
- Enhances error messages in compiler backends to include type information for easier debugging
- Refactors fuzzer targets to use custom wrapper structs and updated wasm-smith configuration patterns
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Bumps wasm-smith version from 0.4.4 to 0.243.0 |
| Cargo.lock | Updates transitive dependencies for wasm-smith and removes old indexmap versions |
| lib/compiler-singlepass/src/codegen.rs | Adds type information to the "unimplemented type" error message |
| lib/compiler-cranelift/src/func_environ.rs | Includes type debug information in the ref.null unsupported feature error |
| fuzz/fuzz_targets/universal_singlepass.rs | Refactors to use custom SinglePassFuzzModule wrapper with new wasm-smith Config API and adds save_wasm_file helper |
| fuzz/fuzz_targets/universal_llvm.rs | Refactors to use custom LLVMPassFuzzModule wrapper with new wasm-smith Config API and adds save_wasm_file helper |
| fuzz/fuzz_targets/universal_cranelift.rs | Refactors to use custom CraneliftPassFuzzModule wrapper with new wasm-smith Config API and adds save_wasm_file helper |
| fuzz/fuzz_targets/metering.rs | Simplifies to use wasm_smith::Module directly instead of custom wrapper |
| fuzz/fuzz_targets/equivalence_universal.rs | Removes custom wrapper and uses wasm_smith::Module directly, updates API calls for store/instance patterns |
| fuzz/fuzz_targets/deterministic.rs | Removes custom wrapper and uses wasm_smith::Module directly |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5931