Append to existing CSP list in Document::set_csp_list #52322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
wpt-pr-bot
approved these changes
May 5, 2025
6dcedf5 to
fc391a4
Compare
73495cf to
2dd49f6
Compare
Signed-off-by: Emmanuel Paul Elom <elomemmanuel007@gmail.com>
2dd49f6 to
9e04adf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Document::set_csp_listmethod now appends new policies to anyexisting
CspListrather than replacing it. This ensures that CSPsfrom multiple sources (e.g., HTTP headers and
<meta>tags) aremerged as expected, following the spec.
This change avoids silently discarding header-defined policies when
a
<meta http-equiv="Content-Security-Policy">is present in thedocument.
Reviewed in servo/servo#36828