Force variant emoji at computed value time #55845
Merged
+175
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous CL – https://chromium-review.googlesource.com/c/chromium/src/+/6916516, the `variant_emoji` was handled at used value time. As part of this CL, we are now moving this behavior to computed value time for spec compliance. The earlier changes are reverted, and a new implementation is added in `style_adjuster` to ensure the variant emoji is set correctly during computed style resolution. Spec - https://www.w3.org/TR/css-color-adjust-1/#forced-colors-properties Bug: 420857717 Change-Id: I15199e424f8cf231e957b89a8487f4b6425dd3f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7081132 Reviewed-by: Alison Maher <almaher@microsoft.com> Commit-Queue: Sejal Anand <sejalanand@microsoft.com> Reviewed-by: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/main@{#1539892}
wpt-pr-bot
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous CL –
https://chromium-review.googlesource.com/c/chromium/src/+/6916516, the
variant_emojiwas handled at used value time. As part of this CL, weare now moving this behavior to computed value time for spec compliance.
The earlier changes are reverted, and a new implementation is added in
style_adjusterto ensure the variant emoji is set correctly duringcomputed style resolution.
Spec -
https://www.w3.org/TR/css-color-adjust-1/#forced-colors-properties
Bug: 420857717
Change-Id: I15199e424f8cf231e957b89a8487f4b6425dd3f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7081132
Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Sejal Anand <sejalanand@microsoft.com>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1539892}