Skip to content

Add tests for new math values of CSS text-transform #16922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 3, 2019
Merged

Add tests for new math values of CSS text-transform #16922

merged 5 commits into from
Jul 3, 2019

Conversation

@fred-wang
Copy link
Contributor

@fred-wang fred-wang commented May 20, 2019

@fred-wang
Copy link
Contributor Author

fred-wang commented May 20, 2019

cc @bkardell @rwlbuis @emilio @bfgeek

The new CSS tests pass in Igalia's chromium-mathml builds.

@rwlbuis
Copy link
Contributor

rwlbuis commented May 21, 2019

LGTM!

@fred-wang fred-wang changed the title Text transform math Add tests for new math values of CSS text-transform May 30, 2019
@fred-wang fred-wang mentioned this pull request Jun 3, 2019
Closed
@fred-wang fred-wang requested a review from svgeesus June 27, 2019 07:29
@fred-wang fred-wang force-pushed the text-transform-math branch from f92f047 to a55ac80 Compare July 2, 2019 12:37
@fred-wang fred-wang requested a review from rwlbuis July 2, 2019 12:37
@fred-wang fred-wang merged commit 1af7e47 into master Jul 3, 2019
@fred-wang fred-wang deleted the text-transform-math branch July 3, 2019 07:47
natechapin pushed a commit to natechapin/wpt that referenced this pull request Aug 23, 2019
@fred-wang @natechapin
Add tests for new math values of CSS text-transform (web-platform-tes…
cb406a0 
…ts#16922)

* Modify mathvariant-transforms.py to generate CSS tests for "text-transform: math-*" (other than math-auto).

* Modify mathvariant-transforms.py to generate tests for single-char <mi> and text-transform: math-auto.

* Add a test to verify 'text-transform: math-auto' on text nodes of different lengths.

* Move text-transform-math tests into their own subdirectory.

* Update meta help to point to mathml core spec.
@bkardell bkardell mentioned this pull request Aug 3, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rwlbuis rwlbuis rwlbuis approved these changes

@fantasai fantasai Awaiting requested review from fantasai

@frivoal frivoal Awaiting requested review from frivoal

@kojiishi kojiishi Awaiting requested review from kojiishi

@nox nox Awaiting requested review from nox

@plinss plinss Awaiting requested review from plinss

@r12a r12a Awaiting requested review from r12a

@svgeesus svgeesus Awaiting requested review from svgeesus

Assignees

@fantasai fantasai

Labels

css-text mathml wg-math

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fred-wang @rwlbuis @fantasai @wpt-pr-bot