Skip to content

Tags: web-platform-tests/wpt

Tags

merge_pr_55863

Toggle merge_pr_55863's commit message
[anchor] Switch position-try-order to use containing-block writing-mode.

It was resolved in:
w3c/csswg-drafts#12869 (comment)

That position-try-order should work in the containing-block writing-mode
and not the candidate writing-mode.

Fixed: 452327359
Change-Id: I60984e57cda1dd57dfcb70e10cbd14a272d972c2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7120318
Commit-Queue: David Grogan <dgrogan@chromium.org>
Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1540244}

merge_pr_55862

Toggle merge_pr_55862's commit message
[gap-decorations] Make `row-rule-outset` into shorthand using new props

This CL makes `column-rule-outset` into a shorthand using the new
longhands w3c/csswg-drafts#12603.

We also implement the paint behavior so that these work for `row`,
moreover, we add new tests for this property, since the existing ones
are using the `row-rule-outset` shorthand.

We also update some existing parsing tests, and uncomment parts of tests
that now work since we introduced the shorthand again.

Recently it was resolved that the `outset` properties will be renamed to
`inset` w3c/csswg-drafts#12848, so they will
need to be renamed in follow up CLs, but since the asymmetric behavior
resolved first, we are implementing that first. It will also allow us to
move to the new inset behavior incrementally.

Bug: 357648037, 440054556
Change-Id: I89086f1df91383468d5379680b7aeb038e99023c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7107409
Reviewed-by: Alison Maher <almaher@microsoft.com>
Commit-Queue: Javier Contreras <javiercon@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1540297}

merge_pr_55861

Toggle merge_pr_55861's commit message
Reland "Refactor menu event handling code [2/4]"

This is a reland of commit 95f912cedcfed49b1360d308897f441882b57f13

Original change's description:
> Refactor menu event handling code [2/4]
>
> Another refactoring CL for menu element code. Previously, the command
> invoker logic was split (and roughly duplicated) between
> HTMLButtonElement and HTMLMenuItemElement. Since both can be command
> invokers, it makes sense to move the command management stuff to the
> common ancestor class, HTMLElement. This CL does that, and de-dupes
> the code out of both subclasses. There is now just one base class
> method that is overridden in sub-classes that can be command
> invokers: CanBeCommandInvoker().
>
> There was also a weird combination of popover activation command
> code, which belongs on HTMLElement because any element can be a
> popover, and menu activation command code, which belongs on the
> HTMLMenuItemElement class, because only that class handles menu
> commands.
>
> This touches a few outside classes like ax_object, which get simpler
> now that they don't have to deal with each case of a command invoker.
>
> There is one behavior change here: now, if a menuitem is *both*
> checkable *and* a sub-menu invoker, the sub-menu wins, and the
> item does not do checked/unchecked behaviors.
>
> I also added a test that seemed missing: make sure only buttons and
> menuitems can be command invokers. Even though <menuitem> isn't
> shipped, this test should pass because it explicitly skips <menuitem>,
> and anyway menuitem isn't included in the HTML5_ELEMENTS list.
>
> Bug: 406566432
> Change-Id: I281eda0eda4b0dced3ad38bd09a488f2c6b1ddf4
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7078858
> Reviewed-by: Dominic Farolino <dom@chromium.org>
> Commit-Queue: Mason Freed <masonf@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1538871}

Bug: 406566432
Change-Id: Iec91410726ae22a3673bdf32eb64aad79f672d6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7113161
Commit-Queue: Dominic Farolino <dom@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Reviewed-by: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1540144}

merge_pr_55860

Toggle merge_pr_55860's commit message
[wpt] Remove the align-dialog-* tests.

It was resolved to remove the {align,justify}-self:dialog values in:
w3c/csswg-drafts#10258 (comment)

Tests for auto-margin ignoring were added in:
fantasai@e283b4a

Change-Id: I33dd95cb45e05ca7a2cf485a846cbfef22986429
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7119879
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1540163}

merge_pr_55859

Toggle merge_pr_55859's commit message
[gap-decorations] Make `column-rule-outset` into shorthand using new …

…props

This CL makes `column-rule-outset` into a shorthand using the new
longhands w3c/csswg-drafts#12603.

We also implement the paint behavior so that these work for `column`,
moreover, we add new tests for this property, since the existing ones
are using the `column-rule-outset` shorthand.

We also update some existing parsing tests, and comment out some parts
of tests that are not applicable yet since `row-rule-outset` and its
longhands will be implemented in following CLs.

We also temporarily remove the `rule-outset` shorthand, but will be
reintroduced once the above is done.

Recently it was resolved that the `outset` properties will be renamed to
`inset` w3c/csswg-drafts#12848, so they will
need to be renamed in follow up CLs, but since the asymmetric behavior
resolved first, we are implementing that first. It will also allow us to
move to the new inset behavior incrementally.

Bug: 357648037, 440054556
Change-Id: I37cdbe50cfabc371344d4bf2aadccd02f1b99c85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7107919
Commit-Queue: Javier Contreras <javiercon@microsoft.com>
Reviewed-by: Alison Maher <almaher@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1540149}

merge_pr_55858

Toggle merge_pr_55858's commit message
Fix a CHECK() in ByteStreamTeeEngine::Start() of a locked stream

Make sure we bail out if ReadableStream::AcquireDefaultReader() failed.

Fixed: 456617547
Bug: 427166012
Change-Id: Ibccc6bfc733e4617566eb00bb2b8d5c8901ae28a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7115848
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1540125}

merge_pr_55857

Toggle merge_pr_55857's commit message
[Masonry] Fix masonry-intrinsic-sizing-rows-004-fr.html

This test was failing because it was using inline-grid for the display
instead of inline-masonry. Update to the correct display type.

This change also adds more descriptive comments for the remaining
groups of intrinsic sizing failures and which CSSWG issues they are
waiting on.

Bug: 343257585
Change-Id: I9377d76f4090862e8627d959f05ef732e7683faf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7114679
Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com>
Auto-Submit: Alison Maher <almaher@microsoft.com>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1540120}

merge_pr_55852

Toggle merge_pr_55852's commit message
Unbreak the try-tactic-basic.html test.

Bug: 457480129
Change-Id: I968e73b47a46ea2e2a82e897cf30d14b819647f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7117241
Commit-Queue: Steinar H Gunderson <sesse@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Auto-Submit: Steinar H Gunderson <sesse@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1539972}

merge_pr_55851

Toggle merge_pr_55851's commit message
Fixes to external/wpt/css/css-viewport/zoom/svg-computed-style.html

Fix typo ('9x' -> '9px') and reset 'zoom' after each loop iteration.

Bug: 453700230
Change-Id: I08efeb3477977bba94a33a5b1cca0bb6cf6be941
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7117003
Auto-Submit: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1539945}