Skip to content

Statisfy PCI scanner with error handler #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Statisfy PCI scanner with error handler #869

wants to merge 2 commits into from

Conversation

@gnadelwartz
Copy link
Contributor

@gnadelwartz gnadelwartz commented Mar 16, 2018 •
edited
Loading

What's in this PR:

  • simple error handler to display a nicer error message as the default simple one liner
  • change to miniserv.pl to call error handler with real return code (e.g. 403), but return 200 to browser
  • to statisfy PCI Scanner the error handler has to be activated in miniserv.conf with error_handler_403=error403.cgi

What's not in this PR:

  • activatvation of error handler
  • configurable return code provided to browser
  • no UI to manage error handler

This was referenced Mar 16, 2018
Closed
Open
@gnadelwartz
Copy link
Contributor Author

gnadelwartz commented Mar 23, 2018 •
edited
Loading

how will we proceed with this topic? try to stisfy PCI scnanner or don't care?

@jcameron
Copy link
Collaborator

jcameron commented Mar 26, 2018

How does this patch resolve the problem? I'm not seeing how that custom error handler is used?

@gnadelwartz
Copy link
Contributor Author

gnadelwartz commented Mar 26, 2018

as stated in the issue I modify the http return code it custom handlers are used and a simple custom handler.

curently the handler has to be activated by hand, so what you possibly missing is UI support for activation?

@cooperdjm
Copy link

cooperdjm commented Apr 28, 2020

So sorry for my ignorance, I am also experiencing the false flag PCI failure. Can someone point me in the direction of how to activate the handler by hand? I am running Webmin 1.941

@cooperdjm
Copy link

cooperdjm commented Apr 28, 2020

So sorry for my ignorance, I am also experiencing the false flag PCI failure. Can someone point me in the direction of how to activate the handler by hand? I am running Webmin 1.941

I think I figured it out, well no, let's be honest I read some more and saw there are instructions to modify the .pl file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gnadelwartz @jcameron @cooperdjm