Search through rotated action log files #1141
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6ec1f01 to
75f0ca4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Webmin for installation with long term logfile archiving requirements, rotating the webmin action log is necessary to wipe them out after some period.
Doing this, the "Webmin Action Log" module is not capable of search through the rotated files.
This patch creates a possible method for handling this with adding a new global config option "logsearch_rotated".
When this is set to 1, the action log modules composes a summary action log file with all rotated contents and uses this as source for index and display.
Alternative way would be to include the filename also in %index. But there is the problem on deleting from %index, when an external logrotate has removed a rotated file.