Fixed error in creating pooled PostgresDB with pgdb driver. #255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repeating the same fix in 35674c8 for pooled (With DBUtils) connections.
Contributor
Author
|
Found that the AttributeError exception was raised when running on Centos 6.2 (don't ask) with web.py & DBUtils installed via pip. |
Contributor
|
hi @PriceChild , is this change still required? |
Contributor
Author
|
@iredmail I believe so, yes. I don't have the same environment around 6 years later, but reviewing the code quickly it looks like connections without DBUtils still fall back: https://github.com/webpy/webpy/blob/master/web/db.py#L1037 but those with pooling don't: https://github.com/webpy/webpy/blob/master/web/db.py#L1048 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeating the same fix in 35674c8 for pooled (With DBUtils) connections.