Skip to content

Fixed the issue with insert returning query #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iredmail merged 2 commits into from
Jun 24, 2020
Merged

Fixed the issue with insert returning query #649

iredmail merged 2 commits into from
Jun 24, 2020

Conversation

@anandology
Copy link
Member

@anandology anandology commented Jun 24, 2020

Closes #648

@anandology
Fixed the issue with insert returning query. (tx pbuckner)
5624361 
The insert ... returning ... query was not getting commited to the db
due to a recent change.

Issue webpy#648
@anandology anandology requested a review from iredmail June 24, 2020 07:35
@anandology anandology force-pushed the 648-insert-returning branch from 1f60363 to 1fea0d9 Compare June 24, 2020 07:37
iredmail
iredmail previously approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@iredmail iredmail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anandology
Copy link
Member Author

anandology commented Jun 24, 2020

These black issues are really frustrating.

@anandology anandology force-pushed the 648-insert-returning branch from 1fea0d9 to 22226c5 Compare June 24, 2020 07:50
@anandology
Added test to ensure the insert...returning query is working correctly.
0067edd 
This test was getting blocked when tried without the fix in the previous
commit.

Issue webpy#648
@anandology anandology force-pushed the 648-insert-returning branch from 22226c5 to 0067edd Compare June 24, 2020 07:54
@anandology
Copy link
Member Author

anandology commented Jun 24, 2020

Fixed the black errors.

@iredmail iredmail merged commit b8e6eba into webpy:master Jun 24, 2020
@anandology anandology deleted the 648-insert-returning branch June 24, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iredmail iredmail iredmail approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

query("insert... returning") fails to commit

2 participants

@anandology @iredmail