-
Notifications
You must be signed in to change notification settings - Fork 1.1k
v0.12.3 Guarantee thread safety #1311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
citkane
wants to merge
24
commits into
webview:master
Choose a base branch
from
citkane:Guarantee-thread-safety
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew_cc and complete define/implement refactoring.
This was referenced Jun 18, 2025
This was referenced Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release guarantees thread safety, thus simplifying the public API and providing the user a cleaner approach to building Webview based applications.
Changed
main, and internally re-directs API calls todispatch_implappropriately.mainthread, and Webview will now throw an exception if not.runandinitSHOULD be called on themainthread, and Webview will now return an error if not.Threads::Threadsas a dependency.pthreadstatically linked, else MSVC builds will fail to resolve threading library paths.Deprecated
webview_dispatchis no longer needed due to guaranteed thread safety. The user can make API calls freely from any context.webview_destroy. The legacy implementation of this API function was in violation of RAII, and likely to cause undefined behaviour. From a user perspective, it is ambiguous and easily confused withwebview_terminate. It now safely re-directs itself towebview_terminateand is no-op if called afterwebview_terminateorwebview_run.Depends on PR's