deltatime of None is raising an error instead of outputting "N/A" in long_form()#843
Merged
Conversation
Contributor
|
Can you give me an example of where See https://github.com/weewx/weewx/blob/master/bin/weewx/tests/test_units.py#L203 |
Contributor
|
My apologies. Now I see the problem. |
tkeffer
added a commit
that referenced
this pull request
Feb 4, 2023
Add PR #843 to change log. Add unit test.
Contributor
|
Thanks, Karen! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the deltatime value is
None, the new funktionlong_form()is raising an error. To output "N/A" (or what is configured to be used in this case) I re-used the first lines offormat()and added the parameterNone_string.