Skip to content

throw exception when get.json can not fonud dag #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ozawau wants to merge 2 commits into from
Closed

throw exception when get.json can not fonud dag #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9738ce7
throw exception when get.json can not fonud dag
Dec 5, 2024
326addb
add unit test
Dec 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions rill-flow-service/src/main/java/com/weibo/rill/flow/service/facade/DAGRuntimeFacade.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,10 @@ public Map<String, Object> getBasicDAGInfo(String executionId, boolean brief) {
dagInfo = longTermStorage.getBasicDAGInfo(executionId);
}

if (dagInfo == null) {
throw new IllegalArgumentException("dag is not found");
}

Map<String, Object> result = makeDAGInfoMap(dagInfo, brief);
result.put("context", getContext(executionId, null));
result.put("invoke_summary", tenantTaskStatistic.getFlowAggregate(executionId));
Expand Down
18 changes: 17 additions & 1 deletion ...ow-service/src/test/groovy/com/weibo/rill/flow/service/facade/DAGRuntimeFacadeTest.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,16 @@ import com.weibo.rill.flow.interfaces.model.task.InvokeTimeInfo
import com.weibo.rill.flow.olympicene.core.model.dag.DAGInfo
import com.weibo.rill.flow.olympicene.core.model.dag.DAGInvokeMsg
import com.weibo.rill.flow.olympicene.core.model.dag.DAGStatus
import com.weibo.rill.flow.service.statistic.TenantTaskStatistic
import com.weibo.rill.flow.service.storage.LongTermStorage
import com.weibo.rill.flow.service.storage.RuntimeStorage
import spock.lang.Specification

class DAGRuntimeFacadeTest extends Specification {
RuntimeStorage runtimeStorage = Mock(RuntimeStorage)
DAGRuntimeFacade dagRuntimeFacade = new DAGRuntimeFacade(runtimeStorage: runtimeStorage)
LongTermStorage longTermStorage = Mock(LongTermStorage)
TenantTaskStatistic tenantTaskStatistic = Mock(TenantTaskStatistic)
DAGRuntimeFacade dagRuntimeFacade = new DAGRuntimeFacade(runtimeStorage: runtimeStorage, longTermStorage: longTermStorage, tenantTaskStatistic: tenantTaskStatistic)

def setup() {
runtimeStorage.clearDAGInfo(*_) >> null
Expand Down Expand Up @@ -89,4 +93,16 @@ class DAGRuntimeFacadeTest extends Specification {
then:
thrown IllegalArgumentException
}

def "test getBasicDAGInfo when DAGInfo does not exist in both storages"() {
given:
runtimeStorage.getBasicDAGInfo("test_execution_id") >> null
longTermStorage.getBasicDAGInfo("test_execution_id") >> null

when:
dagRuntimeFacade.getBasicDAGInfo("test_execution_id", false)

then:
thrown IllegalArgumentException
}
}
Loading