runtime-install: skip qcom-accel-firmware #1493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is "for Qualcomm Technologies data center and Open-vRAN accelerators". It's definitely not needed in the installer environment on x86_64. I'm fairly sure it's not even needed on aarch64 - I don't think that hardware needs to be working during system deployment. Let's check with Peter, though. Signed-off-by: Adam Williamson <awilliam@redhat.com>
40fd717 to
d31407e
Compare
Contributor
Author
|
@nullr0ute is it OK to drop this on aarch64 too? I don't think it should be needed in the installer env, right? |
Pull Request Test Coverage Report for Build 17952584071Details
💛 - Coveralls |
Contributor
Yup, it's never needed for install, they're offload accelerators and would generally be either explicitly specified or installed post install |
Contributor
Author
|
Thanks! Can we get an F43 release/build with this? We need it to squeeze the installer images under 1.2G (which we're probably gonna make the new limit :|) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is "for Qualcomm Technologies data center and Open-vRAN accelerators". It's definitely not needed in the installer environment on x86_64. I'm fairly sure it's not even needed on aarch64 - I don't think that hardware needs to be working during system deployment. Let's check with Peter, though.