Skip to content

🐛 [Bugfix] Update analytics.html for self hosting Umami#402

Merged
welpo merged 2 commits into
welpo:mainfrom
soumendrak:patch-2
Oct 2, 2024
Merged

🐛 [Bugfix] Update analytics.html for self hosting Umami#402
welpo merged 2 commits into
welpo:mainfrom
soumendrak:patch-2

Conversation

@soumendrak

@soumendrak soumendrak commented Sep 26, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

umami.js should be script.js for self hosting URL.

Summary

  • self hosting analytics for Umami fixed.

Related issue

Changes

File name changed

Accessibility

Screenshots

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@soumendrak
Update analytics.html
9221f12 
`umami.js` should be `script.js` for self hosting URL.
@soumendrak soumendrak requested a review from welpo as a code owner September 26, 2024 09:27
@netlify

netlify Bot commented Sep 26, 2024 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit 38f87ee
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/66fd023a8dd51b0008733b24
😎 Deploy Preview https://deploy-preview-402--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@soumendrak

soumendrak commented Sep 26, 2024

Copy link
Copy Markdown
Contributor Author

Also, without giving website-id, it did not work. Maybe the documentation needs to be updated?

@welpo

welpo commented Sep 26, 2024

Copy link
Copy Markdown
Owner

Thanks for the fix!

Also, without giving website-id, it did not work. Maybe the documentation needs to be updated?

Even with this change, you needed to set an [extra.analytics.id]? If so, with what value? I'd appreciate it if you could update the docs, as I don't use Umami myself.

@soumendrak

soumendrak commented Sep 26, 2024

Copy link
Copy Markdown
Contributor Author

ok, I will update this PR with doc changes.

@welpo

welpo commented Sep 26, 2024

Copy link
Copy Markdown
Owner

Thank you!

@soumendrak

soumendrak commented Oct 2, 2024

Copy link
Copy Markdown
Contributor Author

@welpo Please check and suggest if any further changes are needed.

@welpo welpo merged commit 6085139 into welpo:main Oct 2, 2024
@welpo

welpo commented Oct 2, 2024

Copy link
Copy Markdown
Owner

Thank you! Looks good to me

@welpo welpo added the bug Something isn't working label Oct 2, 2024
@soumendrak soumendrak deleted the patch-2 branch October 2, 2024 15:13
welpo added a commit that referenced this pull request Oct 2, 2024
@welpo
📝 docs: update comment in config.toml RE: #402
c50edbd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@welpo welpo Awaiting requested review from welpo welpo is a code owner

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@soumendrak @welpo