🐛 fix: Isso comments in multilingual setups#427
Merged
Conversation
Fixes variable name collision with Zola's built-in current_path that was breaking Isso comments in multilingual sites. Renames the series-related variable to series_path_components to be more descriptive and avoid the conflict. Fixes #426
✅ Deploy Preview for tabi-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a variable name collision that was breaking Isso comments in multilingual sites. The series feature introduced in #406 used a global variable named
current_pathwhich conflicts with Zola's built-in variable of the same name, used by the Isso comments implementation.Related issue
Fixes #426
Changes
current_pathtoseries_path_componentsto avoid collision with Zola's built-in variablepage.htmlType of change
Checklist
theme.tomlwith a sane default for the featureconfig.tomlcommentstheme.tomlcomments