✨ feat: support disabling of the font-subset in header#458
Merged
Conversation
✅ Deploy Preview for tabi-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Owner
|
I like the idea. I'll try to improve the docs (translations + Custom Subset docs) before next Monday and merge. Thank you! |
90c0df0 to
5c5b053
Compare
Owner
|
I've:
Merging now. Thanks! |
This was referenced Jan 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I've created my own custom skin, that doens't use custom font, so I added a way to disable the font-subset.
Related issue
Changes
enable_subset, which is set to true by defaultsheader.htmlto check if the subset is enabledType of change
Checklist
theme.tomlwith a sane default for the featureconfig.tomlin tabi-startconfig.tomlcommentstheme.tomlcomments