Skip to content

✨ feat: parse markdown in post summary & description#517

Merged
welpo merged 5 commits into
welpo:mainfrom
rktjump:markdown-in-post-summaries
Apr 26, 2025
Merged

✨ feat: parse markdown in post summary & description#517
welpo merged 5 commits into
welpo:mainfrom
rktjump:markdown-in-post-summaries

Conversation

@rktjump

@rktjump rktjump commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

Summary

Enable markdown in post summaries.

Related issue

#512

Accessibility

Screenshots

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have updated config.toml in tabi-start
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@rktjump rktjump requested a review from welpo as a code owner April 15, 2025 18:02
@netlify

netlify Bot commented Apr 15, 2025

Copy link
Copy Markdown

Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit 8440af1
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/680d1c52f886d40008780733
😎 Deploy Preview https://deploy-preview-517--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@welpo

welpo commented Apr 15, 2025

Copy link
Copy Markdown
Owner

Thank you!

Could you create a new post, just for testing, where the issue with codeblocks is apparent?

You can commit to this PR branch. That will help me see the issue (both in the demo and when I get the code for the PR) and fix it

@rktjump

rktjump commented Apr 16, 2025

Copy link
Copy Markdown
Contributor Author

hope this helps!

(this is a very old IOCCC entry: https://github.com/ioccc-src/winner/blob/master/1988/westley/westley.c)

@welpo

welpo commented Apr 16, 2025

Copy link
Copy Markdown
Owner

It does help!

I think we should parse markdown for the feed too, right? Could you update the template atom. xml?

@rktjump

rktjump commented Apr 23, 2025

Copy link
Copy Markdown
Contributor Author

Sorry for late reply. I am not sure about markdown in atom/rss feeds; are html tags allowed there?

Looking at the spec: https://validator.w3.org/feed/docs/atom.html#text

title, summary, content, and rights contain human-readable text, usually in small quantities. The type attribute determines how this information is encoded (default="text")

So it seems like just stripping markdown is fine there? But I'm happy to be proven wrong.

& standardise separator selection for mobile-only
@welpo

welpo commented Apr 26, 2025

Copy link
Copy Markdown
Owner

Thanks for the reference, @rktjump!

Let's leave the feed as is.

I've fixed the CSS (well, @serginogal did. Thank you!). Merging now!

@welpo welpo changed the title enable markdown parsing in post summaries ✨ feat: parse markdown in post summaries Apr 26, 2025
@welpo welpo changed the title ✨ feat: parse markdown in post summaries ✨ feat: parse markdown in post summary & description Apr 26, 2025
@welpo welpo added the enhancement New feature or request label Apr 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants