Skip to content

🐛 fix(feed): prioritise description > summary#525

Merged
welpo merged 7 commits into
welpo:mainfrom
tzinm:main
May 11, 2025
Merged

🐛 fix(feed): prioritise description > summary#525
welpo merged 7 commits into
welpo:mainfrom
tzinm:main

Conversation

@tzinm

@tzinm tzinm commented May 11, 2025

Copy link
Copy Markdown
Contributor

Summary

Currently, tabi handles description field and summary with different priority depending on the context. This PR gives priority to description field in feeds to be consistent in homepage and feed.

Related issue

Related to #523 issue.

Changes

Update atom.xml giving priority to description field over summary.

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have updated config.toml in tabi-start
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@tzinm tzinm requested a review from welpo as a code owner May 11, 2025 09:47
@netlify

netlify Bot commented May 11, 2025

Copy link
Copy Markdown

Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit e806556
🔍 Latest deploy log https://app.netlify.com/sites/tabi-demo/deploys/68207218679a6f0008c4086b
😎 Deploy Preview https://deploy-preview-525--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tzinm

tzinm commented May 11, 2025

Copy link
Copy Markdown
Contributor Author

I don't know why git-sumi is detecting that the title is not matching the required pattern.

In my local repository I also got the error with the commit message.

💬 Input: ":bug: fix: prioritise description > summary in feed"
️❗ Header does not match the required pattern: '^([\p{Emoji_Presentation}\p{Extended_Pictographic}](?:\u{FE0F})?\u{200D}?) \w'
❌ Error: Found 1 linting error

The --force flag didn't work for me.

@welpo welpo changed the title : bug: fix: prioritise description > summary in feed 🐛 fix: prioritise description > summary in feed May 11, 2025
@welpo welpo changed the title 🐛 fix: prioritise description > summary in feed 🐛 fix(feed): prioritise description > summary May 11, 2025
@welpo

welpo commented May 11, 2025

Copy link
Copy Markdown
Owner

I don't know why git-sumi is detecting that the title is not matching the required pattern.

I prefer the actual emoji UTF-8 character(s) rather than the :emoji: style, and that's what git-sumi validates :)

@welpo

welpo commented May 11, 2025

Copy link
Copy Markdown
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants