Skip to content

✨ feat: extend tabi <head> and <body> elements#528

Merged
welpo merged 5 commits into
welpo:mainfrom
axis7818:axis7818/extend-tabi-templates
Jun 1, 2025
Merged

✨ feat: extend tabi <head> and <body> elements#528
welpo merged 5 commits into
welpo:mainfrom
axis7818:axis7818/extend-tabi-templates

Conversation

@axis7818

@axis7818 axis7818 commented May 24, 2025

Copy link
Copy Markdown
Contributor

Summary

This pull request adds optional includes to the end of the <head> and <body> elements in Tabi. Users can provide these templates in their repositories to add additional content to the respective elements.

See #526 for related discussion.

Changes

Only the template files have added include statements for optional templates. So, users can provide these without needing to supply additional configuration.

Type of change

  • Bug fix (fixes an issue without altering functionality)
  • New feature (adds non-breaking functionality)
  • Breaking change (alters existing functionality)
  • UI/UX improvement (enhances user interface without altering functionality)
  • Refactor (improves code quality without altering functionality)
  • Documentation update
  • Other (please describe below)

Checklist

  • I have verified the accessibility of my changes
  • I have tested all possible scenarios for this change
  • I have updated theme.toml with a sane default for the feature
  • I have updated config.toml in tabi-start
  • I have made corresponding changes to the documentation:
    • Updated config.toml comments
    • Updated theme.toml comments
    • Updated "Mastering tabi" post in English
    • (Optional) Updated "Mastering tabi" post in Spanish
    • (Optional) Updated "Mastering tabi" post in Catalan

@axis7818 axis7818 requested a review from welpo as a code owner May 24, 2025 23:55
@netlify

netlify Bot commented May 24, 2025

Copy link
Copy Markdown

Deploy Preview for tabi-demo ready!

Name Link
🔨 Latest commit b0e6061
🔍 Latest deploy log https://app.netlify.com/projects/tabi-demo/deploys/683c6d97e0affb0008e2c107
😎 Deploy Preview https://deploy-preview-528--tabi-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@welpo

welpo commented May 25, 2025

Copy link
Copy Markdown
Owner

Looks good! Thank you!!

Can you add the documentation to the Mastering tabi post in English? :)

@axis7818 axis7818 changed the title ✨ feat: Extend Tabi <head> and <body> Elements ✨ feat: extend tabi <head> and <body> elements May 31, 2025
@axis7818

Copy link
Copy Markdown
Contributor Author

Given that this does not require additional settings, I wonder if it makes sense in the mastering tabi settings post? Maybe a different (existing or new) post would be better?

@welpo

welpo commented Jun 1, 2025

Copy link
Copy Markdown
Owner

I wonder if it makes sense in the mastering tabi settings post? Maybe a different (existing or new) post would be better?

Fair point! But I like to have everything in the post :) Thanks for this! Merging now

@welpo welpo added the enhancement New feature or request label Jun 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants