feat: support assign json #286
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
看不太懂这个是支持的什么功能。我们之前不支持json["key"] = another_json 这样的写法么？ |
Author
|
是的，之前不支持 |
Contributor
|
这个做法，是否有内存泄露的可能性呢？例如，如果用于赋值的another_json是一个中间节点会怎么样？
…------------------ Original ------------------
From: PhoenixChen98 ***@***.***>
Date: Sun,Jun 1,2025 8:26 PM
To: wfrest/wfrest ***@***.***>
Cc: xiehan ***@***.***>, Comment ***@***.***>
Subject: Re: [wfrest/wfrest] feat: support assign json (PR #286)
PhoenixChen98 left a comment (wfrest/wfrest#286)
是的，之前不支持
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you commented.Message ID: ***@***.***>
|
Author
|
我是调用的已有方法，里面是copy的，应该没内存泄露风险 |
Barenboim
reviewed
Jun 1, 2025
| } | ||
| if (parent_ != nullptr) | ||
| { | ||
| assign(other); |
Author
There was a problem hiding this comment.
其实update_arr和push_back等一系列方法也都没有右值接口，我这里加上move意义也不大了
Contributor
There was a problem hiding this comment.
但是这样语义上有点不对了。感觉是可以实现的，我想想。
danielsofran
approved these changes
Nov 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support assign json such as:
json["key"] = jsonObject;