You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Service worker registration selection for iframes with srcdoc #321
A document loading for an iframe with srcdoc attribute doesn't go through fetch algorithm. (That is, it uses the given value instead of fetching a resource.) So currently the selection (match) of the service worker registration for the navigation doesn't occur.
In the recent service worker f2f, it has been discussed that once the iframesrcdoc document is created, the resource requests for that document should be controlled by the containing frame's service worker. This bit should be specified.
I think I might want to add some steps in Navigate for the selection of the registration for local urls.
Also, I noticed that I cannot set the client's active worker to the registration's active worker in Handle Fetch step 12.5 as the target browsing context's Window object has not been created by that time. So setting an active worker to a window client should also be specified in the Navigate algorithm?
Yeah, blob and data URLs do go through Fetch (not sure how the latter should be handled, perhaps it should always be without service worker). about:blank doesn't always.
You probably want to hook the service worker stuff into when a document is created. And similarly at the place where a worker is created.
Activity
Service worker registration selection for iframe srcdoc
annevk commentedon Nov 9, 2015
This is also true for
about:blank, right? And forblob/dataURLs?jungkees commentedon Nov 9, 2015
I think those at least go through fetch (as local url requests)? If so, this text (https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#selection) seems to cover that. But sure it'd be better to specify that in the related steps directly.
jungkees commentedon Nov 9, 2015
I think I might want to add some steps in Navigate for the selection of the registration for local urls.
Also, I noticed that I cannot set the client's active worker to the registration's active worker in Handle Fetch step 12.5 as the target browsing context's Window object has not been created by that time. So setting an active worker to a window client should also be specified in the Navigate algorithm?
annevk commentedon Nov 9, 2015
Yeah,
blobanddataURLs do go through Fetch (not sure how the latter should be handled, perhaps it should always be without service worker).about:blankdoesn't always.You probably want to hook the service worker stuff into when a document is created. And similarly at the place where a worker is created.
jungkees commentedon Nov 10, 2015
Yes, please assign this issue to me. (Note that it'll take time as I'm planning a two weeks vacation later this month.)
Specify service worker registration selection
Specify service worker registration selection
Specify service worker registration selection
Specify service worker registration selection