Report ResourceTiming for video posters and image inputs #7539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 tasks
domenic
reviewed
Feb 12, 2022
source
Outdated
| source</span> given the <code>input</code> element to <span data-x="concept-event-fire">fire an | ||
| event</span> named <code data-x="event-error">error</code> on the <code>input</code> element.</p> | ||
| by the <span>networking task source</span> once the resource has been fetched, must perform the | ||
| following steps given a <span data-x="concept-response">response</span> <var>response</var>:</p> |
There was a problem hiding this comment.
Can this use processResponseEndOfBody too? I guess by merging these two steps into the existing two-step algorithm above that ends with "Fetch request".
The intermediate paragraphs are a mess, but I think we can mostly just keep them as-is, while improving this specific one that you're touching by merging it into the more formal algorithm.
domenic
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(See WHATWG Working Mode: Changes for more details.)
/input.html ( diff )
/media.html ( diff )