refactor: use u32_from_slice#1128
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors code to use a centralized u32_from_slice utility function instead of manual byte array conversions. The change standardizes the way 32-bit values are extracted from byte slices across multiple architecture-specific modules.
- Replaces manual
u32::from_le_bytes(*bytes.first_chunk::<4>().expect(...))calls withu32_from_slice(bytes) - Adds imports for the
u32_from_sliceutility function in affected modules - Simplifies byte-to-u32 conversion logic in instruction decoding and PLT entry parsing
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| linker-utils/src/riscv64.rs | Refactored RISC-V instruction value extraction to use u32_from_slice |
| linker-utils/src/aarch64.rs | Updated AArch64 instruction parsing and relaxation code to use u32_from_slice |
| linker-diff/src/riscv64.rs | Simplified PLT entry decoding by replacing manual byte array construction |
| linker-diff/src/asm_diff.rs | Updated relocation value reading to use u32_from_slice for 4-byte values |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
davidlattimore
approved these changes
Sep 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.