Skip to content

Handle missing GNU_PROPERTY .note.gnu.property values#1222

Merged
marxin merged 2 commits into
wild-linker:mainfrom
marxin:add-missing-GNU_PROPERTY_X
Oct 17, 2025
Merged

Handle missing GNU_PROPERTY .note.gnu.property values#1222
marxin merged 2 commits into
wild-linker:mainfrom
marxin:add-missing-GNU_PROPERTY_X

Conversation

@marxin

@marxin marxin commented Oct 16, 2025

Copy link
Copy Markdown
Collaborator

Noticed while building qtwayland package where coverage for the following property was missing:

  GNU                  0x00000040	NT_GNU_PROPERTY_TYPE_0
      Properties: 1_needed: indirect external access

@marxin marxin force-pushed the add-missing-GNU_PROPERTY_X branch from e648c19 to 772347a Compare October 16, 2025 15:33
@davidlattimore

Copy link
Copy Markdown
Member

The failure message from gcc was a bit hard to spot, so I did #1224 to make it a bit easier.

Not sure if you'd already started looking at a solution to the unsupported flag (sorry if you had), but I thought I'd make the checking of compiler flags mechanism more generic - #1225

@davidlattimore davidlattimore left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once CI passes :)

@marxin

marxin commented Oct 17, 2025

Copy link
Copy Markdown
Collaborator Author

Thank you @davidlattimore for the infrastructure improving changes!

Noticed while building `qtwayland` package where coverage
for the following property was missing:
```
  GNU                  0x00000040	NT_GNU_PROPERTY_TYPE_0
      Properties: 1_needed: indirect external access
```
@marxin marxin force-pushed the add-missing-GNU_PROPERTY_X branch from 772347a to fbfa158 Compare October 17, 2025 06:15
@marxin marxin merged commit bc44ab8 into wild-linker:main Oct 17, 2025
20 checks passed
@marxin marxin deleted the add-missing-GNU_PROPERTY_X branch October 17, 2025 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants