refactor: decouple OutputKind from Args#1293
Conversation
146bff1 to
39f5b17
Compare
| pub(crate) is_dynamic_executable: AtomicBool, | ||
| relocation_model: RelocationModel, | ||
| pub(crate) relocation_model: RelocationModel, | ||
| pub(crate) outputting_executable: bool, |
There was a problem hiding this comment.
This field could use a better name, but I haven't got anything fitting.
There was a problem hiding this comment.
Perhaps is_output_executable or should_output_executable. Another option would be to make this an enum. The only trouble is that the obvious name for such an enum is... OutputKind, which would mean we'd need a new name for the other OutputKind. Or maybe this one could be OutputClass.
| pub(crate) is_dynamic_executable: AtomicBool, | ||
| relocation_model: RelocationModel, | ||
| pub(crate) relocation_model: RelocationModel, | ||
| pub(crate) outputting_executable: bool, |
There was a problem hiding this comment.
Perhaps is_output_executable or should_output_executable. Another option would be to make this an enum. The only trouble is that the obvious name for such an enum is... OutputKind, which would mean we'd need a new name for the other OutputKind. Or maybe this one could be OutputClass.
No description provided.