Skip to content

Nix: Update for inclusion in Nixpkgs#1318

Merged
davidlattimore merged 7 commits into
wild-linker:mainfrom
RossSmyth:nixUpdate
Nov 21, 2025
Merged

Nix: Update for inclusion in Nixpkgs#1318
davidlattimore merged 7 commits into
wild-linker:mainfrom
RossSmyth:nixUpdate

Conversation

@RossSmyth
Copy link
Copy Markdown
Contributor

@RossSmyth RossSmyth commented Nov 19, 2025

Wild is now in Nixpkgs, which is great. So in this PR I move some stuff around because of that.

  1. Bump the lock file
  2. Have the overlay set wild-unwrapped as Wild needs to be wrapped to find libraries correctly. The wrapper is in Nixpkgs.
  3. Run the tests that are in Nixpkgs (these are the same tests as were in the Wild repo before)
  4. Remove the stdenv adapter from the Wild repo
  5. Remove the two seperate overlay files and centralize to just one
  6. Move the GCC wrappers to their own file

Then there is a commit that does several things all at once since there's not a great way to split most of them up:

  1. Ensure all accesses of Wild are done through the overlay
  2. Move the check inputs into the derivation
  3. Remove some of the hacks for running unit tests by using stdenvNoCC when running unit tests

@davidlattimore
Copy link
Copy Markdown
Member

davidlattimore commented Nov 19, 2025

Thank! Looks good. There's a typo in one of the files - see CI failure.

I've recently changed the repo to only allow squash merges, since it makes it easier to write the release notes because all commits link back to the relevant PR. Is this PR OK to squash, or should we figure out an alternative?

@RossSmyth
Copy link
Copy Markdown
Contributor Author

RossSmyth commented Nov 19, 2025

Is this PR OK to squash, or should we figure out an alternative?

Yeah this is fine to squash.

@dawnofmidnight @Noratrieb if yall have any input :ferrisclueless:

davidlattimore
davidlattimore approved these changes Nov 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@davidlattimore davidlattimore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait until tomorrow to merge this to give others a chance to comment

@whispersofthedawn
Copy link
Copy Markdown

whispersofthedawn commented Nov 20, 2025

I have no particular comments. This generally seems reasonable to me, but this interacts with a lot of machinery I don't really understand, so I can't offer anything particularly meaningful.

@davidlattimore davidlattimore merged commit 505b3f8 into wild-linker:main Nov 21, 2025
20 checks passed
@RossSmyth RossSmyth deleted the nixUpdate branch November 21, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidlattimore davidlattimore davidlattimore approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@RossSmyth @davidlattimore @whispersofthedawn