refactor: Move dynamic symbol definitions onto layout#1368
Merged
Conversation
The epilogue still allocates space for these and writes them, but it's convenient to just store them on the layout. This eliminates one bit of code where we have to get access to the epilogue. Perhaps more importantly, it changes merge_dynamic_symbol_definitions to only take shared state, which means it could in future be run in parallel with something else.
d387d7e to
b361a86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The epilogue still allocates space for these and writes them, but it's convenient to just store them on the layout. This eliminates one bit of code where we have to get access to the epilogue. Perhaps more importantly, it changes merge_dynamic_symbol_definitions to only take shared state, which means it could in future be run in parallel with something else.