Skip to content

fix: Do not bail when encountering unsupported SFrame version#1577

Merged
mati865 merged 3 commits into
wild-linker:mainfrom
mati865:push-snumtpzmpvot
Feb 24, 2026
Merged

fix: Do not bail when encountering unsupported SFrame version#1577
mati865 merged 3 commits into
wild-linker:mainfrom
mati865:push-snumtpzmpvot

Conversation

@mati865

@mati865 mati865 commented Feb 20, 2026

Copy link
Copy Markdown
Member

cc #1576

@mati865

mati865 commented Feb 20, 2026

Copy link
Copy Markdown
Member Author

I can remove thiserror if we don't plan to use it in more places. I'm just used to this kind of handling errors.

@mati865 mati865 marked this pull request as draft February 20, 2026 16:55
@mati865 mati865 marked this pull request as ready for review February 20, 2026 18:50

@davidlattimore davidlattimore left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be onboard to switch to thiserror if that's the consensus of the team. We shouldn't just have thiserror in one place and string-based errors everywhere else, although I assume that wasn't your intention.

I can see the use for something like thiserror in libraries where the users of the library need to differentiate between the different errors. I'm not aware of cases where users of libwild need to do that though.

Or is it not about differentiating the error kinds, but just that you prefer this of raising errors?

Interested as to what @marxin and @lapla-cogito think

@mati865

mati865 commented Feb 20, 2026

Copy link
Copy Markdown
Member Author

In this case, being able to differentiate the error is handy. It can be done without thiserror as well, that was just more natural to me.

@davidlattimore davidlattimore left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm inclined to say let's go ahead and merge this as-is. We can always change it later. I'm interested in other people's opinions as to how we should be doing error reporting. Perhaps a topic for our next monthly meeting.

@lapla-cogito lapla-cogito left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm in favor of using thiserror when it makes the implementation cleaner, but I'm not sure how common such cases are beyond SFrame.

@marxin

marxin commented Feb 21, 2026

Copy link
Copy Markdown
Collaborator

Don't have a strong preference here - I am slightly leaning towards the opaque error type (e.g. bail!), but don't have any strong arguments against the thiserror. But I would like to see an unified approach for the error handling.

@mati865

mati865 commented Feb 23, 2026

Copy link
Copy Markdown
Member Author

Removed thiserror. Now the implementation is more in line with VersionScriptError and LinkerScriptError, although they handle it that way because of winnow.

@mati865 mati865 merged commit f2d9fab into wild-linker:main Feb 24, 2026
20 checks passed
@mati865 mati865 deleted the push-snumtpzmpvot branch February 24, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants