fix: Don't bypass dynamic symbol lookup due to unused hidden in archive#1837
Merged
Conversation
Member
|
Whether purposely or accidentally, this fixes x86_64 error in #1561. |
Member
Author
|
In retrospect, I should have realised, but didn't. I was working on range extension thunks and thought I'd test on chrome, hit an issue that at first I thought was related to the thunk work, but then realised it wasn't, so separated it out. Sorry if I ended up taking the problem you were working on! |
Member
|
No problem, it's good to have to it working. |
mati865
added a commit
that referenced
this pull request
Apr 16, 2026
They went out of sync back in 1c40a0c. This used to cause linking of x86_64 Android Chromium to fail as described in #1561 (comment), but no longer does since #1837.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.