fix: Prevent GC of linker script symbol aliases#1956
Merged
Conversation
mati865
reviewed
May 20, 2026
| //#DiffIgnore:section.got | ||
| //#DiffIgnore:section.gnu.version_d.alignment | ||
| //#DiffIgnore:version_d.verdef_1 | ||
| //#DiffIgnore:dynsym.mysql_affected_rows.section |
Member
There was a problem hiding this comment.
Neither LD nor LLD export this symbol. Is it an issue with version script parser or the linker?
Member
Author
There was a problem hiding this comment.
Not sure where the bug is, but I've added a TODO.
mati865
approved these changes
May 20, 2026
a440df9 to
bc3518e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1948. Note, that dealing with archive activation is left to a subsequent PR.
The newly added test has two configs. Config defsym-obj was already passing. Config script-obj was failing and is what's being fixed by this PR.