Skip to content

Convert PQ::ConnInfo#sslmode to an enum type #314

Description

@jgaskins

The Symbol type in Crystal is pretty barebones and could represent any symbol that has been written into any Crystal code in the app, but PQ::ConnInfo#sslmode accepts a very low-cardinality set of values, which seems like a great use case for an enum type.

Changing types can have backwards-compatibility implications, but changing the type of PQ::ConnInfo#sslmode should have a very small impact, if any at all. There are very few use cases for PQ at all (a Postgres connector, which we've already got covered by this shard, and maybe building a custom backend?) and for PQ::ConnInfo specifically I can't imagine any outside this shard.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions