steepによる型チェックを修正してCIに組み込んだ #63
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gimei.addressesの戻り値の型がおかしかったので直したRomajiの型がないので必要なものだけ定義した
Array#sampleの戻り値にnilが含まれるためにエラーになっていたのをtype assertionを利用して解決した
次の2つのエラーは
steep checkuses wrong context for#define_methodin a singleton · Issue #380 · soutaro/steepにあるように、steepが特異クラスにおけるdefine_methodのブロックコンテキストを誤って解釈していることが原因と思われる。extend Forwardableする方法が現状ないため無視するようにしたGimei.namesと@namesはsteepに期待通りに解釈させる方法が見つからなかったのでひとまずuntypedのままにしておく