Skip to content

Add php override file used by many shared hosting #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
LukeTowers merged 1 commit into from
Dec 9, 2025
Merged

Add php override file used by many shared hosting #1426

LukeTowers merged 1 commit into from
Dec 9, 2025
+1 −0

Conversation

@mjauvin
Copy link
Member

@mjauvin mjauvin commented Dec 6, 2025 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

  • Chores
    • Updated system configuration to include additional files in the mirrored assets list, enhancing the platform's file distribution and availability handling.

✏️ Tip: You can customize this high-level summary in your review settings.

@mjauvin mjauvin requested a review from LukeTowers December 6, 2025 13:57
@mjauvin mjauvin self-assigned this Dec 6, 2025
@mjauvin mjauvin added the maintenance PRs that fix bugs, are translation changes or make only minor changes label Dec 6, 2025
@coderabbitai
Copy link

coderabbitai bot commented Dec 6, 2025 •
edited
Loading

Walkthrough

The change adds .user.ini to the protected $files property array in the WinterMirror class. This file is now included in the list of publicly mirrored assets alongside other root-level configuration and metadata files like .htaccess, robots.txt, and sitemap.xml.

Changes

Cohort / File(s) Summary
WinterMirror configuration update
modules/system/console/WinterMirror.php		 Added .user.ini to the protected $files array for public mirroring

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • LukeTowers

Poem

🐰 A whisker-twitch, a file so fine,
.user.ini joins the line,
With .htaccess and robots.txt,
Mirrored mirrors, perfectly mixed! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding '.user.ini' to the mirrored files list for shared hosting compatibility.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mirror-user-ini

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@LukeTowers
Copy link
Member

LukeTowers commented Dec 6, 2025

Why do you want that file mirrored to the public directory @mjauvin? That seems like the kind of file one wouldn't want mirrored at all.

coderabbitai[bot]
coderabbitai bot reviewed Dec 6, 2025
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
modules/system/console/WinterMirror.php (1)

34-43: Adding .user.ini to mirrored files is reasonable; confirm server blocks direct access if needed

Including .user.ini alongside .htaccess in $files keeps per‑directory PHP overrides working when using the mirrored public folder, and the implementation will safely no‑op when the file is absent. The change itself looks good.

Operationally, if your .user.ini can contain sensitive configuration, double‑check that your webserver (or .htaccess) already prevents direct HTTP access to this file in the mirrored public directory so you don’t accidentally expose it.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 046e5a5 and 5786b84.

📒 Files selected for processing (1)
  • modules/system/console/WinterMirror.php (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (9)
  • GitHub Check: windows-latest / PHP 8.2
  • GitHub Check: windows-latest / PHP 8.3
  • GitHub Check: windows-latest / PHP 8.4
  • GitHub Check: ubuntu-latest / PHP 8.2
  • GitHub Check: ubuntu-latest / PHP 8.4
  • GitHub Check: windows-latest / PHP 8.1
  • GitHub Check: ubuntu-latest / PHP 8.3
  • GitHub Check: ubuntu-latest / PHP 8.1
  • GitHub Check: windows-latest / JavaScript

@mjauvin
Copy link
Member Author

mjauvin commented Dec 6, 2025

Because it's required when the site uses the mirror for the overrides to be seen by the webserver.

It's the equivalent of php.ini

@LukeTowers LukeTowers merged commit e86009b into develop Dec 9, 2025
15 checks passed
@LukeTowers LukeTowers deleted the mirror-user-ini branch December 9, 2025 21:13
@LukeTowers LukeTowers added this to the 1.2.10 milestone Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@LukeTowers LukeTowers LukeTowers approved these changes

Assignees

@mjauvin mjauvin

Labels

maintenance PRs that fix bugs, are translation changes or make only minor changes

Projects

None yet

Milestone

1.2.10

Development

Successfully merging this pull request may close these issues.

3 participants

@mjauvin @LukeTowers