Add TransferFromRewardNotifierTestBase and related test contracts #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkeating
reviewed
May 21, 2025
| /// @notice Base contract for testing TransferFromRewardNotifier functionality. | ||
| /// @dev Extends StakerTestBase and simulates calling notify function on TransferFromRewardNotifier. | ||
| /// This contract is designed to be used in conjunction with the deployment scripts in | ||
| /// `src/script/notifiers/DeployTransferFromRewardNotifier.sol`. |
Collaborator
There was a problem hiding this comment.
Same as other pr there is some missing natspec. Should look like https://github.com/withtally/staker/pull/126/files#diff-4f52ef6ad04cce0828d588f28c5c762d17886d4b7db7b4ecddc4976cdef38971R10
|
Coverage after merging feature/modular-testing-transfer-from-reward-notifier into feature/modular-testing will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
alexkeating
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransferFromRewardNotifierTestBaseTransferFromRewardNotifierwith the same tests inStandardTestSuite