Handle edge case in assert #149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funkyenough
reviewed
May 29, 2025
| vm.stopPrank(); | ||
| } | ||
|
|
||
| /// @notice A test helper that wraps calling the `stake` function on the underlying Staker |
Collaborator
There was a problem hiding this comment.
(Arbitrary Comment related to Line 36)
Here's a nit: with the refactor, _setDelegateeScoreAboveThreshold is only used in StakedBinaryEligibilityOracleEarningPowerCalculatorTestBase. It is probably cleaner to move the function there, and potentially just merge the logic into _stakeBelowThreshold if it not going to be used anywhere else.
b5099e3 to
c113cc7
Compare
|
Coverage after merging feature/remove-epc-assumption into feature/modular-testing-binary-eligibility-oracle-earning-power-calculator will be
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
16a8dd8
into
feature/modular-testing-binary-eligibility-oracle-earning-power-calculator
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.