fix: support fail function signature with deprecated params #383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for putting this up! Just started working on this project again but will make sure to get this merged soon! |
f634761 to
e2be922
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I was getting a type error with some old code using the
attrkeyword argument of thefailmethod. According to the function signature, theattrdoes exist, but it's deprecated.Solution
Add the missing keyword arguments to the
failand mark them as deprecated. Additionally we add an info diagnostic marked as deprecated to these usages of this parameter.would also appreciate any feedback on the pull request 🙏 i did see that there was a comment on not applying DRY for function params so would like to help if appropriate here